Compiling libelas as static library

• petrack_core is no longer built using -fpermissive
• libelas is compiled as static library and then linked to petrack
• libelas is now turned OFF by default (since stereo functionality as a whole is)

When libelas *is *turned on, we still see the warnings (-fpermissive cannot be silenced; its already deprecation errors into warnings). One could first compile libelas and then the PeTrack target, to have less clutter.

Since fpermissive is mandatory, this does mean nonconformant code is used. We should evaluate libelas as a depndecy as a whole (is it updated regularly, on what compilers does it work, what alternatives are there) once we choose to reintroduce the stereo functionality.

Closes #12 (closed)

CMakeLists.txt

@@ -50,7 +50,7 @@ print_var(STEREO)
 option(AVI "Use Avi File from Point Grey (currently not supported)" OFF)
 print_var(AVI)
 
-option(LIBELAS "Use Libelas" ON)
+option(LIBELAS "Use Libelas" OFF)
 print_var(LIBELAS)
 
 option(DISABLE_STEREO "Disable Stereo features (currently must be taken)" ON)
@@ -156,7 +156,7 @@ add_executable(petrack src/main.cpp)
 target_link_libraries(petrack PRIVATE petrack_core)
 
 # TODO we should remove this compile option and be more strict
-target_compile_options(petrack_core PRIVATE "-fpermissive" ${COMMON_COMPILE_OPTIONS})
+target_compile_options(petrack_core PRIVATE ${COMMON_COMPILE_OPTIONS})
 target_compile_definitions(petrack_core PUBLIC STEREO_DISABLED)
 
 #**********************************************************
@@ -205,13 +205,16 @@ target_sources(petrack_core PRIVATE src/analysePlot.cpp)
 #*************************************************************
 if(LIBELAS)
   target_compile_definitions(petrack_core PRIVATE LIBELAS)
-  target_sources(petrack_core PRIVATE
+  add_library(libelas STATIC
     src/libelas/elasDescriptor.cpp
     src/libelas/elas.cpp
     src/libelas/elasFilter.cpp
     src/libelas/elasMatrix.cpp
     src/libelas/elasTriangle.cpp
   )
+  target_include_directories(libelas PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)
+  target_compile_options(libelas PRIVATE "-fpermissive")
+  target_link_libraries(petrack_core PRIVATE libelas)
 endif(LIBELAS)
 
 # TODO currently not available