Skip to content
Snippets Groups Projects

Compiling libelas as static library

Merged d.kilic requested to merge 12-compile-libelas-as-static-library into master
All threads resolved!
  • petrack_core is no longer built using -fpermissive
  • libelas is compiled as static library and then linked to petrack
  • libelas is now turned OFF by default (since stereo functionality as a whole is)

When libelas *is *turned on, we still see the warnings (-fpermissive cannot be silenced; its already deprecation errors into warnings). One could first compile libelas and then the PeTrack target, to have less clutter.

Since fpermissive is mandatory, this does mean nonconformant code is used. We should evaluate libelas as a depndecy as a whole (is it updated regularly, on what compilers does it work, what alternatives are there) once we choose to reintroduce the stereo functionality.

Closes #12 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • d.kilic
  • d.kilic
  • d.kilic
    • Author Owner
      Resolved by d.kilic

      General question: Should we also move libelas to a different folder. Or should we wait until we update it? If we do, we should keep track of which version we are using. From the copyright comment it seem to be from 2013sh

      By Schrödter, Tobias on 2020-07-03T12:07:38 (imported from GitLab project)

  • d.kilic added 1 commit

    added 1 commit

    • 3f425fe4 - Apply suggestion to CMakeLists.txt

    Compare with previous version

    By Kilic, Deniz on 2020-07-03T11:57:34 (imported from GitLab project)

  • d.kilic added 1 commit

    added 1 commit

    • c049411b - Apply suggestion to CMakeLists.txt

    Compare with previous version

    By Kilic, Deniz on 2020-07-03T11:57:40 (imported from GitLab project)

  • d.kilic added 1 commit

    added 1 commit

    • bd29ff12 - Apply suggestion to CMakeLists.txt

    Compare with previous version

    By Kilic, Deniz on 2020-07-03T11:57:44 (imported from GitLab project)

  • d.kilic resolved all threads

    resolved all threads

    By Kilic, Deniz on 2020-07-03T11:57:51 (imported from GitLab project)

  • d.kilic added 1 commit

    added 1 commit

    • 7167af11 - Apply suggestion to CMakeLists.txt

    Compare with previous version

    By Kilic, Deniz on 2020-07-03T11:57:53 (imported from GitLab project)

  • d.kilic added 3 commits

    added 3 commits

    Compare with previous version

    By Kilic, Deniz on 2020-07-06T16:39:14 (imported from GitLab project)

  • d.kilic mentioned in issue #19 (closed)

    mentioned in issue #19 (closed)

    By Schrödter, Tobias on 2020-07-09T10:22:26 (imported from GitLab project)

  • d.kilic resolved all threads

    resolved all threads

    By Schrödter, Tobias on 2020-07-09T10:22:53 (imported from GitLab project)

  • d.kilic mentioned in commit 74008502

    mentioned in commit 74008502

    By Schrödter, Tobias on 2020-07-09T10:24:04 (imported from GitLab project)

  • merged

    By Schrödter, Tobias on 2020-07-09T10:24:04 (imported from GitLab project)

  • Please register or sign in to reply
    Loading