Skip to content
Snippets Groups Projects

Unload loaded video when loading pet with empty SRC

Merged d.kilic requested to merge 375-open-empty-sequence into master
  • When loading empty src
    • Reset Animation
    • Update Sequence
    • Reset mImg, mImage and mFilteredImage (i.e. all images saved in Petrack)
    • Fade In LogoItem
  • Change LogoItem to use QPropertyAnimation for fading
  • Change updateSceneRect to properly shrink sceneRect when loading empty sequence

Feedback needed: Fading animation speed, currently 2 seconds.

Closes #375 (closed)

Related !260 (merged)

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by Schrödter, Tobias

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading