Core: Further consolidate ICoordSystem and children
- For historic reasons, CoordSystem1D and CoordSystem2D differ more than necessary.
- CoordSystem2D contains hard-coded axes, which makes flattening (#555 (closed)) difficult.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Wuttke, Joachim added Core simplify labels
- Wuttke, Joachim assigned to @j.wuttke
assigned to @j.wuttke
- Author Owner
TODO:
-
#73 (closed) remove ROI[see comment] - CoordSystem2D: convert
std::vector<AxisData> m_axes
to aCloneableVector<IAxis>
- CoordSystem1D: generalize
std::unique_ptr<const IAxis> m_axis
to aCloneableVector<IAxis> m_axes
- move
m_axes
toICoordSystem
-
make CoordSystem2D independent of[done in 1.20]Device
subdirectoriesBeam
,Detector
,ProDetector
-
move CoordSystem2D to[done in 1.20]Device/Coord
Edited by Wuttke, Joachim -
- m.puchner mentioned in merge request !88 (merged)
mentioned in merge request !88 (merged)
- Contributor
#73 (closed) is implemented. However, ROI has not been removed, but already replaced by a new design.
The refactoring in #73 (closed) included also the ROI-relevant things around the
CoordSystem
classes. They are already freed from any ROI knowledge, and furthermore the dependency from class/folderDetector
and folderProDetector
has been removed.Edited by m.puchner - Wuttke, Joachim unassigned @j.wuttke
unassigned @j.wuttke
- Wuttke, Joachim mentioned in merge request !1554 (closed)
mentioned in merge request !1554 (closed)
- Wuttke, Joachim marked this issue as related to #308 (closed)
marked this issue as related to #308 (closed)
- Wuttke, Joachim marked this issue as related to #555 (closed)
marked this issue as related to #555 (closed)
- Wuttke, Joachim marked this issue as related to #478 (closed)
marked this issue as related to #478 (closed)
- Wuttke, Joachim marked this issue as related to #505 (closed)
marked this issue as related to #505 (closed)
- Wuttke, Joachim mentioned in issue #545
mentioned in issue #545
- Wuttke, Joachim changed the description
changed the description
- Wuttke, Joachim mentioned in commit 28f4ec01
mentioned in commit 28f4ec01
- Wuttke, Joachim mentioned in merge request !1557 (merged)
mentioned in merge request !1557 (merged)
- Wuttke, Joachim mentioned in commit 1a478360
mentioned in commit 1a478360
- Wuttke, Joachim marked this issue as related to #557 (closed)
marked this issue as related to #557 (closed)
- Wuttke, Joachim mentioned in merge request !1559 (merged)
mentioned in merge request !1559 (merged)
- Wuttke, Joachim mentioned in commit c86080e1
mentioned in commit c86080e1