[m.0] Update projection plots on selection/moving projection (#1044) ()

Merging branch 'm.0'  into 'main'.

See merge request !2783

GUI/Model/Mask/OverlayItem.h

@@ -27,7 +27,7 @@ public:
     virtual ~OverlayItem();
 
 signals:
-    void maskGeometryChanged();
+    void maskGeometryChanged() const;
     void maskVisibilityChanged();
     void maskToBeDestroyed();
 };

GUI/View/Canvas/MaskEditorCanvas.cpp

@@ -87,11 +87,11 @@ MaskEditorCanvas::MaskEditorCanvas()
             &MaskEditorCanvas::deleteCurrentItem);
 
     // automatically switch to the appropriate projection tab
-    connect(m_scene, &MaskGraphicsScene::lineItemMoved, [this](LineItem* sender) {
-        if (dynamic_cast<HorizontalLineItem*>(sender)
+    connect(m_scene, &MaskGraphicsScene::lineItemMoved, [this](const LineItem* sender) {
+        if (dynamic_cast<const HorizontalLineItem*>(sender)
             && (m_current_activity != Canvas2DMode::VERTICAL_PRJN))
             emit changeProjectionsTabRequest(Canvas2DMode::HORIZONTAL_PRJN);
-        if (dynamic_cast<VerticalLineItem*>(sender)
+        if (dynamic_cast<const VerticalLineItem*>(sender)
             && (m_current_activity != Canvas2DMode::HORIZONTAL_PRJN))
             emit changeProjectionsTabRequest(Canvas2DMode::VERTICAL_PRJN);
     });

GUI/View/Overlay/LineOverlays.cpp

@@ -84,6 +84,7 @@ void HorizontalLineOverlay::onChangedY()
 {
     setBlockOnProperty(true);
     m_item->setPos(y2coo(this->y()));
+    emit m_item->maskGeometryChanged();
     setBlockOnProperty(false);
 }
 
@@ -131,6 +132,7 @@ void VerticalLineOverlay::onChangedX()
 {
     setBlockOnProperty(true);
     m_item->setPos(x2coo(this->x()));
+    emit m_item->maskGeometryChanged();
     setBlockOnProperty(false);
 }
 

GUI/View/Scene/MaskGraphicsScene.cpp

@@ -374,13 +374,14 @@ IOverlay* MaskGraphicsScene::registerOverlay(OverlayItem* item, bool is_projecti
         if (m_mouse_is_pressed)
             gDoc->setModified(); // manual mask movement
     });
-    if (auto* line_item = dynamic_cast<LineItem*>(item)) {
-        connect(line_item, &OverlayItem::maskGeometryChanged, [this, line_item] {
-            emit lineItemMoved(line_item); // -> update projections plot
-        });
-        connect(line_item, &OverlayItem::maskToBeDestroyed,
-                [this, line_item] { emit lineItemDeleted(line_item); });
-    }
+    if (is_projection)
+        if (auto* line_item = dynamic_cast<LineItem*>(item)) {
+            connect(line_item, &OverlayItem::maskGeometryChanged, [this, line_item] {
+                emit lineItemMoved(line_item); // -> update projections plot
+            });
+            connect(line_item, &OverlayItem::maskToBeDestroyed,
+                    [this, line_item] { emit lineItemDeleted(line_item); });
+        }
     connect(m_plot.get(), &QCustomPlot::afterReplot, overlay, &IOverlay::onGeometryChange);
     connect(item, &OverlayItem::maskGeometryChanged, overlay, &IOverlay::onGeometryChange);
     if (auto* mask_item = dynamic_cast<MaskItem*>(item)) {
@@ -523,6 +524,11 @@ void MaskGraphicsScene::onProjSetChanged()
     connectOverlaySelection(false);
     selectOnlyGivenItem(m_mask2overlay[m_prjns->currentItem()]);
     connectOverlaySelection(true);
+
+    // switch projection plot
+    const auto* line_item = dynamic_cast<const LineItem*>(m_prjns->currentItem());
+    ASSERT(line_item);
+    emit lineItemMoved(line_item);
 }
 
 void MaskGraphicsScene::onSceneSelectionChanged()
@@ -544,6 +550,13 @@ void MaskGraphicsScene::onSceneSelectionChanged()
         MasksSet* current_set = modelOfMaskItem(selected_item);
         current_set->setCurrentIndex(current_set->index_of(selected_item));
         unselectOtherModelThan(current_set);
+
+        // switch projection plot
+        if (current_set == m_prjns) {
+            const auto* line_item = dynamic_cast<const LineItem*>(selected_item);
+            ASSERT(line_item);
+            emit lineItemMoved(line_item);
+        }
     }
     connectMaskSet(true);
     connectProjSet(true);

GUI/View/Scene/MaskGraphicsScene.h

@@ -54,7 +54,7 @@ signals:
     void mouseSelectionChanged();
     void itemContextMenuRequest(const QPoint& point);
     void lineItemProcessed();
-    void lineItemMoved(LineItem* sender);
+    void lineItemMoved(const LineItem* sender);
     void lineItemDeleted(const LineItem* sender);
 
 public slots: