Skip to content

Deleted unused class-member: camValues, distValues, isExtCalib

ar.graf requested to merge 379-delete-obsolete-members-of-extrcalibration into master

removed unused and moved one member to be local to a function, readability slightly decreased

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by d.kilic

Merge request reports

Loading