Resolve "colorpicker doesn't consider border correctly"
Color picker now uses getMousePosOnImage to get the mouse position instead of relying on its own logic. This solves problems with border and distortion.
Also, the RectPlotItem now does not delete the last map, but instead replaces it with a default one (letting everything through), so the indices still work.
Closes #57 (closed)
Merge request reports
Activity
added 1 commit
- f68ed4d4 - Fixed: not considering border correctly in color picker
By Kilic, Deniz on 2020-09-09T16:15:57 (imported from GitLab project)
added 1 commit
- e1232533 - - Using helper function to find mouse position
By Kilic, Deniz on 2020-09-10T09:35:52 (imported from GitLab project)
added 1 commit
- 76d84e25 - Fixed unit test and added safety guards around map getters
By Kilic, Deniz on 2020-09-14T17:12:42 (imported from GitLab project)
added 1 commit
- 12bc12e6 - Creating colorMaps with default color, so invalid color can be used as sign for currupted map
By Kilic, Deniz on 2020-09-15T09:36:35 (imported from GitLab project)
added 1 commit
- 205fbf59 - Never let RectPlotItem mMaps list be empty
By Kilic, Deniz on 2020-09-16T09:38:01 (imported from GitLab project)
added 44 commits
-
205fbf59...a79788d7 - 39 commits from branch
master
- 0f8dcb94 - Fixed: not considering border correctly in color picker
- d62c8fed - - Using helper function to find mouse position
- 9964ce60 - Fixed unit test and added safety guards around map getters
- 28a12c3e - Creating colorMaps with default color, so invalid color can be used as sign for currupted map
- 9126c49b - Never let RectPlotItem mMaps list be empty
By Kilic, Deniz on 2020-10-22T08:31:30 (imported from GitLab project)
Toggle commit list-
205fbf59...a79788d7 - 39 commits from branch
added 97 commits
-
9126c49b...b9740d60 - 92 commits from branch
master
- d67b9973 - Fixed: not considering border correctly in color picker
- fc6a379b - - Using helper function to find mouse position
- 586f76dd - Fixed unit test and added safety guards around map getters
- 91a1ea6f - Creating colorMaps with default color, so invalid color can be used as sign for currupted map
- 96abba88 - Never let RectPlotItem mMaps list be empty
Toggle commit list-
9126c49b...b9740d60 - 92 commits from branch
- Resolved by Schrödter, Tobias
- Resolved by Schrödter, Tobias
- Resolved by Schrödter, Tobias
- Resolved by Schrödter, Tobias
added 9 commits
-
96abba88...e405fb4e - 6 commits from branch
master
- 241b3ae1 - Change clickedColor's type to QColor
- 1c8c6716 - Errormessage for wrong index at call of delMap
- 6c67ef76 - Merge branch 'master' into 57-colorpicker-doesn-t-consider-border-correctly
Toggle commit list-
96abba88...e405fb4e - 6 commits from branch
added 21 commits
-
6c67ef76...669b4cb4 - 14 commits from branch
master
- f23ba5e5 - Fixed: not considering border correctly in color picker
- a059478e - - Using helper function to find mouse position
- b4d5b4b0 - Fixed unit test and added safety guards around map getters
- d07dbfb7 - Creating colorMaps with default color, so invalid color can be used as sign for currupted map
- 356c906d - Never let RectPlotItem mMaps list be empty
- 16455079 - Change clickedColor's type to QColor
- bc08b2f7 - Errormessage for wrong index at call of delMap
Toggle commit list-
6c67ef76...669b4cb4 - 14 commits from branch
mentioned in commit 09e80bc0