Skip to content
Snippets Groups Projects

Add test for pet-file

Merged d.kilic requested to merge 371-add-test-for-pet-file into master
  • Add regression test for checking whether 00_empty.pet gets saved (mostly) exactly as it is now
  • Also fixed error in reading in FROM_COLOR in colorMarkerWidget.cpp (assigned saturation to value)

For motivation, see issue #371 (closed)

Closes #371 (closed)

Reviewer Checklist

Formatting

  • the pre-build checks succeed

General code quality

  • naming conventions are met (see .clang-tidy for detailed information)
  • no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)

General usability

  • old versions of pet-files are still loadable

Only if changes in UI

  • new elements are also saved and loaded from pet-file
  • check if tab order is still correct
  • all new SpinBoxes are promoted
  • new keybindings added to Petrack::keyBindings()
Edited by Schrödter, Tobias

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • d.kilic added CI medium labels

    added CI medium labels

  • Schrödter, Tobias marked the checklist item the pre-build checks succeed as completed

    marked the checklist item the pre-build checks succeed as completed

  • Schrödter, Tobias marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

    marked the checklist item naming conventions are met (see .clang-tidy for detailed information) as completed

  • Schrödter, Tobias marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

    marked the checklist item no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) as completed

  • Schrödter, Tobias marked the checklist item old versions of pet-files are still loadable as completed

    marked the checklist item old versions of pet-files are still loadable as completed

  • Schrödter, Tobias marked the checklist item new elements are also saved and loaded from pet-file as completed

    marked the checklist item new elements are also saved and loaded from pet-file as completed

  • Schrödter, Tobias marked the checklist item check if tab order is still correct as completed

    marked the checklist item check if tab order is still correct as completed

  • Schrödter, Tobias marked the checklist item all new SpinBoxes are promoted as completed

    marked the checklist item all new SpinBoxes are promoted as completed

  • Schrödter, Tobias marked the checklist item new keybindings added to Petrack::keyBindings() as completed

    marked the checklist item new keybindings added to Petrack::keyBindings() as completed

  • Schrödter, Tobias approved this merge request

    approved this merge request

  • d.kilic added 5 commits

    added 5 commits

    Compare with previous version

  • d.kilic enabled an automatic merge when the pipeline for 7256437b succeeds

    enabled an automatic merge when the pipeline for 7256437b succeeds

  • merged

  • d.kilic mentioned in commit 66883d5d

    mentioned in commit 66883d5d

Please register or sign in to reply
Loading