Increase allowed border size to 750
All threads resolved!
All threads resolved!
Closes #361 (closed)
Reviewer Checklist
General code quality
-
naming conventions are met (see .clang-tidy for detailed information) -
no static analyzer warnings in new code parts (e.g., use clang-tidy for checking)
General usability
-
old versions of pet-files are still loadable
Only if changes in UI
-
new elements are also saved and loaded from pet-file -
check if tab order is still correct -
all new SpinBoxes are promoted -
new keybindings added to Petrack::keyBindings()
Merge request reports
Activity
Filter activity
added bug calibration high labels
added 1 commit
- 9b41a9bf - Use setValue method to ensure throwing errors when out of bounds values are imported from pet file
- Resolved by Schrödter, Tobias
Could you add a
try-catch
-block, such that PeTrack does not crash? SeeIntrinsicBox::setIntrinsicCameraParams
.Also, I just noticed that we are in an invalid state in
IntrinsicBox::setIntrinsicCameraParams
if somesetValue
after the first throws; i.e. while the parameters used are not changed (mParams
is the same), the parameters displayed are changed (at least some)But that's another issue.
enabled an automatic merge when the pipeline for 6821c732 succeeds
mentioned in commit 753e05ca
Please register or sign in to reply