Skip to content
Snippets Groups Projects

Issue03

All threads resolved!
Merged Trageser requested to merge issue03 into main
All threads resolved!

This should fix the principle problem. However there are some annotation i have to make:

The original problem which made it necessary to deactivate the tests under windows was either:

  • catch2.dll was not in the same directory
  • OR the QObject::connect in 10_logger.cpp

Both resulted in linking issues. The first was easy to fix, the second not so much. I have not fully understood what is going wrong there, but I realized the same problem lies dormant in demo_trigger.cpp. If one introduces a connect with gLogger in that file it will produce linking errors as well. Due to this, I came to the conclusion, a redesign of 10_logger.cpp and an additional issue for investigating this problem with gLogger and connect would be the proper way. It's more specific and it makes test available under windows again right away.

In addition I encountered some problem with libqcr's version of catch2.hpp. At some point I realized that Steca has a different version of catch. I tried to copy and use Steca version of catch in libqcr and so far it works perfectly. Since these changes were made by you and I cannot tell you the full scope of these. If there are good reasons for not use Steca version of catch2.hpp in libqcr please tell me.

Resolves issue #3 (closed)

Edited by Trageser

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Wuttke, Joachim
  • Wuttke, Joachim
  • Good to see this solved.

    No objection to upgrading Catch2.

  • Wuttke, Joachim approved this merge request

    approved this merge request

  • Trageser added 2 commits

    added 2 commits

    • 070f3b43 - removed extension .exe for windows
    • 2902d382 - build test On should be default

    Compare with previous version

  • Trageser added 1 commit

    added 1 commit

    • 94ec4c46 - Simpliefied strucuture of CMakeLists.txt by setting value for...

    Compare with previous version

  • Trageser resolved all threads

    resolved all threads

  • merged

  • Trageser mentioned in commit 738393af

    mentioned in commit 738393af

  • Please register or sign in to reply
    Loading