Reduce include dependences in GUI; break cyclic dependence between View and Model
- renamed directories from plural to singular (Views->View, Utils->Util, etc etc)
- made GUI/Model independent of GUI/View
- organized GUI/Model into subdirectories
- moved GUI/main to App
- moved files from GUI/View to GUI/View/Toplevel
- broke most cyclic dependences between subdirectories of GUI/View (the remaining ones are mostly for calling functions from ProjectManager that should be moved down to ProjectDocument)
- obtained two subdirectories of GUI/Model with non-cyclic dependences (Component, IO); all other subdirectories still forming a big interdependent cluster
- removed some unused source files
- removed numerous unneeded includes
- corrected a few relative include paths
- splitted several source pairs into two pairs
- splitted class Application into two (ApplicationSettings vs SessionData)
- renamed many namespaces
- shuffled code in several functions to treat anomalous conditions first; no else after return
- substituted QWidget::parentWidget for m_mainWindow and other self-made solutions
- converted SavePlotAssistant from class to namespace
- moved some enum definitions to low-level file ID.h
Edited by Wuttke, Joachim
Merge request reports
Activity
requested review from @m.puchner
added 1 commit
- da1805d4 - in App/main, do without global pointers (Win error)
added 1 commit
- 33e30a11 - in App/main, do without global pointers (Win error)
added 17 commits
- c226da51 - code layout
- 610157fa - rm GUI/Items, all files moved to GUI/Models
- 6985f982 - clang-format
- e5c3d9e5 - Data no longer depends on Domain
- 9dc4ea8d - Fit no longer depends on Varia
- 0cd0d244 - mv; rm include
- 06e95f26 - mv
- 0219be4d - class -> namespace
- 6cd81ee1 - rm unused include
- 82ad7a9b - mv
- 8f442aa8 - mv; anon namespace impl to top of file
- 57ef0520 - ItemFileNameUtils: pass name, not item
- 48250a8d - decouple ItemFileNameUtils from items
- f1c554ba - reintegrate directories GUI/Models/State and /Mapper
- d17073fd - mv out of Varia/
- f47ca40d - rm GUI/Models/Varia
- 61532136 - mv Mask
Toggle commit listadded 14 commits
- 6a63d541 - treat anomalous case first
- 09ab40a3 - rename -> GUI/Utils
- bd10894c - use QVector::fromStdVector instead of our own fct; rename Utils files
- 579f7432 - reorganize GUI::Utils::String vs Path
- 2c2cc481 - rm std::ostream& operator<<(std::ostream& stream, const QString& str)
- 7ca376a0 - rename GUI directories to singular
- 1aedff09 - local fct to anon namespace
- 2cce05ac - rm unused fct readTextFile
- ed0fd7eb - sort String vs Path, and other cleanup
- 35aa8818 - rm fct
- ea3d6001 - rm includes
- 0c2ef6f6 - repairs
- fb794382 - better namespace name
- ab48a188 - restore auto files
Toggle commit listadded 11 commits
- c2ad5283 - decouple ToDomain from other sources in Domain/
- 3dca3bd2 - mv Resolution to Instrument/
- 576b5cfc - mv ftcs out of ToDomain
- 322e143d - corr use of ASSERT
- 42702a5d - mv ToDomain back to Domain/
- 58a3196a - fct to anon namespace on top
- 177598f3 - rename ns; forward decl
- ba3771dc - mv fct; rm include
- 1aca5007 - clang-format
- 28c5af83 - rm include
- c156e1bf - mv fct
Toggle commit listadded 9 commits
- 5f57bc28 - mv etc
- 066056ad - mv => GUI/Model/Component now only outgoing dependencies
- 5001409e - const -> inline
- 50dd2d29 - mv
- 05e79e2d - new dir GUI/Model/IO
- 3e349a26 - more files -> IO
- 19590c57 - rmdir GUI/Model/Parameter/
- abc9bf21 - rm using
- e503ee8a - Util->Model unless also used by View or Widget
Toggle commit listadded 9 commits
- 9257bb3b - mv from GUI/Util to where it is used
- 046e90cc - + GUI/Util/EditUtil
- 1406278f - in GUI/Util split MessageBox vs EditUtil
- 351c9afa - corr: move back hostosinfo
- 0777e6db - camel case file name
- ee319d0c - rm include
- e091a3e6 - rm include
- 3334e266 - split off CreateDetails
- 233f4d68 - special editor widget -> View/SubInstrument
Toggle commit listadded 3 commits
Please register or sign in to reply