Skip to content
Snippets Groups Projects

Improve the SWIG API to the Fit module

Merged Ammar Nejati requested to merge a.cleanUpSWIG_Fit into main

The SWIG API to the Fit module is revised completely to make the minimizer's call to Python functions and conversion of results more explicit. Auxiliary functions are added to call a Python callable with a Parameters instance and convert the result to double or a C++ std::vector as required.

The Python extension to the Minimizer class is updated and improved.

The unneeded PyCallback C++ class and ParametersIterator Python class are removed.

Edited by Ammar Nejati

Merge request reports

Pipeline #170691 passed

Pipeline passed for 23e2c0a8 on a.cleanUpSWIG_Fit

Merged by Ammar NejatiAmmar Nejati 2 months ago (Nov 5, 2024 1:17pm UTC)

Merge details

  • Changes merged into with 2714b19c.
  • Deleted the source branch.

Pipeline #170696 passed

Pipeline passed for 2714b19c on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Wuttke, Joachim approved this merge request

    approved this merge request

  • Ammar Nejati added 34 commits

    added 34 commits

    • b94f9017...a2ff54cd - 22 commits from branch main
    • a2ff54cd...4418ae9d - 2 earlier commits
    • df1e4da4 - libBornAgainFit.i: clean up
    • e2e209ef - libBornAgainFit.i: Minimizer: minor improvements
    • bb8f477d - libBornAgainFit.i: add aux. functions to call a Python callable and convert...
    • be7fa72c - libBornAgainFit.i: upd the Python extention to Minimizer::minimize
    • d17a5d9b - libBornAgainFit.i:Minimizer: extend the class to accept a Python callback
    • 029bf0dd - libBornAgainFit.i: clean up
    • 8ab37d2b - Minimizer: rm unneeded overloaded method
    • 971bf4f2 - SwigLib.cmake: no SWIG-wrapper header is produced after the changes
    • 80a9655f - rm unneeded PyCallback
    • 6515fce0 - SWIG API: update

    Compare with previous version

  • Ammar Nejati resolved all threads

    resolved all threads

  • Ammar Nejati added 1 commit

    added 1 commit

    • f8d94fde - Minimizer: add a note on the new mechanism to accept a Python function as minimization objective

    Compare with previous version

  • Ammar Nejati added 4 commits

    added 4 commits

    • 929ab0a1 - Minimizer: add a note on the new mechanism to accept a Python function as minimization objective
    • 9f70bb92 - SwigLib.cmake: no SWIG-wrapper header is produced after the changes
    • ceb09a8b - rm unneeded PyCallback
    • 368ab241 - SWIG API: update

    Compare with previous version

  • Ammar Nejati added 8 commits

    added 8 commits

    • fe61ea9f - libBornAgainFit.i: upd the Python extension to Minimizer::minimize
    • 6306227e - libBornAgainFit.i:Minimizer: extend the class to accept a Python callback
    • ea107cb6 - libBornAgainFit.i: clean up
    • 1a75b630 - Minimizer: rm unneeded overloaded method
    • 355d1d68 - Minimizer: add a note on the new mechanism to accept a Python function as minimization objective
    • c2d67a16 - SwigLib.cmake: no SWIG-wrapper header is produced after the changes
    • 9b4c0577 - rm unneeded PyCallback
    • 23e2c0a8 - SWIG API: update

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading