Skip to content
Snippets Groups Projects

GUI: close global access to 'InstrumentLibrary'

Merged GUI: close global access to 'InstrumentLibrary'
i404 into main
All threads resolved!
Merged Mikhail Svechnikov requested to merge i404 into main
All threads resolved!

According to #404 (closed) InstrumentLibrary is passed as argument only to classes that really need it:

MainWindow--->InstrumentView--->InstrumentListView

Merge request reports

Pipeline #85353 passed

Stage: build

Pipeline passed for a83da8f8 on i404

Approved by
Wuttke, Joachim

Merged by Mikhail SvechnikovMikhail Svechnikov 2 years ago (Jan 9, 2023 4:41pm UTC)

Merge details

  • Changes merged into main with 24ca9ecd.
  • Deleted the source branch.

  • Mentions issue #404 (closed)

  • Auto-merge enabled

Pipeline #85355 passed

Stage: build

Pipeline passed for 24ca9ecd on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Wuttke, Joachim approved this merge request

    approved this merge request

  • Wuttke, Joachim mentioned in issue #404 (closed)

    mentioned in issue #404 (closed)

  • Mikhail Svechnikov added 1 commit

    added 1 commit

    • d5388e27 - InstrumentLibrary is moved from 'main' to InstrumentListView

    Compare with previous version

  • Mikhail Svechnikov added 1 commit

    added 1 commit

    • 85b7c25d - InstrumentLibrary is moved from 'main' to InstrumentListView

    Compare with previous version

  • Mikhail Svechnikov resolved all threads

    resolved all threads

  • Mikhail Svechnikov enabled an automatic merge when the pipeline for 85b7c25d succeeds

    enabled an automatic merge when the pipeline for 85b7c25d succeeds

  • Mikhail Svechnikov aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Mikhail Svechnikov added 1 commit

    added 1 commit

    • 446304f2 - InstrumentLibrary is moved from 'main' to InstrumentListView

    Compare with previous version

  • Mikhail Svechnikov enabled an automatic merge when the pipeline for 446304f2 succeeds

    enabled an automatic merge when the pipeline for 446304f2 succeeds

  • Mikhail Svechnikov aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Mikhail Svechnikov added 1 commit

    added 1 commit

    Compare with previous version

  • Mikhail Svechnikov enabled an automatic merge when the pipeline for a83da8f8 succeeds

    enabled an automatic merge when the pipeline for a83da8f8 succeeds

  • Mikhail Svechnikov merged

    merged

  • Mikhail Svechnikov mentioned in commit 24ca9ecd

    mentioned in commit 24ca9ecd

    • Please register or sign in to reply