disambiguate class names `InstrumentEditController` and `InstrumentsEditController`

We have source pairs

• GUI/Model/Device/InstrumentsEditController,
• GUI/View/Instrument/InstrumentEditController. The classes defined in these files have almost the same name, except for singular/plural "Instrument" without/with s.

This is confusing at first, and requires extra concentration in perpetuity.

Furthermore: Is a controller a model or a view? It can not be both.

Proposals for better names?

By the way, class InstrumentsEditController has a member InstrumentModel* m_instruments. Why has the member variable a plural name while pointing to a class that has a singular name?

added GUI discuss in team! labels

mentioned in merge request !1321 (closed)

changed milestone to %20 GUI refactoring

I stumbled again over these two files. We really should help ourselves by choosing file names that are easier to distinguish.

Proposal: InstrumentNotifier and MultiInstrument. @m.svechnikov - ok? or other proposal?

InstrumentEditController is described as Single-instrument-adapter to InstrumentsEditorController. Following this description I would suggest to rename it to SingleInstrumentEditController. A bit long but self-descriptive name.

InstrumentsEditorController can remain untouched.

InstrumentEditController controls nothing, just sends a few notifications. Hence my proposal InstrumentNotifier.

For the other class, how about InstrumentsLibrarian?

InstrumentsLibrarian can be understood as related to InstrumentLibrary that is undesirable.

Maybe then InstrumentNotifier and MultiInstrumentNotifier?

ok, I'll go for that. Thanks.

mentioned in commit d9d2d820

mentioned in merge request !1421 (merged)

mentioned in commit ca119f3d

closed with merge request !1421 (merged)