simplify

Core/Parametrization/IParameterized.cpp

@@ -75,11 +75,10 @@ void IParameterized::setParameterValue(const std::string &name, double value)
         m_parameters->setParameterValue(name, value);
     } else {
         std::unique_ptr<ParameterPool> P_pool { createParameterTree() };
-        if(name.find('*') != std::string::npos) {
+        if(name.find('*') != std::string::npos)
             P_pool->setMatchedParametersValue(name, value);
-        } else {
+        else
             P_pool->setParameterValue(name, value);
-        }
     }
     onChange();
 }

Core/Parametrization/RealParameterWrapper.cpp

@@ -54,20 +54,20 @@ void RealParameterWrapper::checkNull() const
 {
     if(isNull())
         throw Exceptions::NullPointerException(
-            "RealParameterWrapper::getValue() -> Attempt to access uninitialised pointer.");
+            "BUG in RealParameterWrapper::getValue() -> Attempt to access uninitialised pointer.");
 }
 
 void RealParameterWrapper::setValue(double value)
 {
     checkNull();
-    if(value != *m_data) {
-        if(m_limits.isInRange(value) && !m_limits.isFixed()) {
-            *m_data = value;
-            m_parent->onChange();
-        } else {
-            throw Exceptions::OutOfBoundsException("Value not in range");
-        }
-    }
+    if(value == *m_data)
+        return; // nothing to do
+    if(!m_limits.isInRange(value))
+        throw Exceptions::OutOfBoundsException("Value not in range");
+    if(m_limits.isFixed())
+        throw Exceptions::OutOfBoundsException("Parameter is fixed");
+    *m_data = value;
+    m_parent->onChange();
 }
 
 void RealParameterWrapper::swapContent(RealParameterWrapper& other)