Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
BornAgain
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
mlz
BornAgain
Commits
e2217c67
Commit
e2217c67
authored
3 years ago
by
t.knopff
Browse files
Options
Downloads
Patches
Plain Diff
Remove obsolete SessionItem::addGroupProperty (string version)
parent
0796ec30
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!382
Remove obsolete code, resolves issue about Qt debug functions
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
GUI/Models/SessionItem.cpp
+0
-24
0 additions, 24 deletions
GUI/Models/SessionItem.cpp
GUI/Models/SessionItem.h
+0
-1
0 additions, 1 deletion
GUI/Models/SessionItem.h
with
0 additions
and
25 deletions
GUI/Models/SessionItem.cpp
+
0
−
24
View file @
e2217c67
...
@@ -299,30 +299,6 @@ void SessionItem::setItemValue(const QString& tag, const QVariant& variant) cons
...
@@ -299,30 +299,6 @@ void SessionItem::setItemValue(const QString& tag, const QVariant& variant) cons
getItem
(
tag
)
->
setValue
(
variant
);
getItem
(
tag
)
->
setValue
(
variant
);
}
}
//! Creates new group item and register new tag, returns GroupItem.
SessionItem
*
SessionItem
::
addGroupProperty
(
const
QString
&
groupTag
,
const
QString
&
groupType
)
{
if
(
GUI
::
Session
::
ItemUtils
::
IsValidGroup
(
groupType
))
{
GroupInfo
groupInfo
=
GUI
::
Session
::
ItemUtils
::
GetGroupInfo
(
groupType
);
return
addGroupProperty
(
groupTag
,
groupInfo
);
}
// # migration Remove this branch at any convenient occasion. It is not used anymore.
// # migration Suggestion is to throw if not
// GUI::Session::ItemUtils::IsValidGroup(groupType)
qWarning
()
<<
"SessionItem::addGroupProperty() is obsolete for single property items. Use "
"::addProperty<> instead."
;
// create single item
registerTag
(
groupTag
,
1
,
1
,
QStringList
()
<<
groupType
);
SessionItem
*
result
=
GUI
::
Model
::
ItemFactory
::
CreateItem
(
groupType
);
ASSERT
(
result
);
result
->
setDisplayName
(
groupTag
);
bool
success
=
insertItem
(
0
,
result
,
groupTag
);
ASSERT
(
success
);
return
result
;
}
SessionItem
*
SessionItem
::
addGroupProperty
(
const
QString
&
groupTag
,
const
GroupInfo
&
groupInfo
)
SessionItem
*
SessionItem
::
addGroupProperty
(
const
QString
&
groupTag
,
const
GroupInfo
&
groupInfo
)
{
{
GroupItem
*
groupItem
=
GUI
::
Model
::
ItemFactory
::
CreateItem
<
GroupItem
>
();
GroupItem
*
groupItem
=
GUI
::
Model
::
ItemFactory
::
CreateItem
<
GroupItem
>
();
...
...
This diff is collapsed.
Click to expand it.
GUI/Models/SessionItem.h
+
0
−
1
View file @
e2217c67
...
@@ -257,7 +257,6 @@ public:
...
@@ -257,7 +257,6 @@ public:
void
setItemValue
(
const
QString
&
tag
,
const
QVariant
&
variant
)
const
;
void
setItemValue
(
const
QString
&
tag
,
const
QVariant
&
variant
)
const
;
// convenience functions for groups
// convenience functions for groups
SessionItem
*
addGroupProperty
(
const
QString
&
groupTag
,
const
QString
&
groupType
);
SessionItem
*
addGroupProperty
(
const
QString
&
groupTag
,
const
GroupInfo
&
groupInfo
);
SessionItem
*
addGroupProperty
(
const
QString
&
groupTag
,
const
GroupInfo
&
groupInfo
);
SessionItem
*
setGroupProperty
(
const
QString
&
groupTag
,
const
QString
&
modelType
)
const
;
SessionItem
*
setGroupProperty
(
const
QString
&
groupTag
,
const
QString
&
modelType
)
const
;
template
<
typename
T
>
T
*
setGroupPropertyType
(
const
QString
&
groupTag
);
template
<
typename
T
>
T
*
setGroupPropertyType
(
const
QString
&
groupTag
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment