simplify RealSpace (3D) view - simplified "locked view" handling

GUI/View/Realspace/RealSpaceCanvas.cpp

@@ -31,7 +31,6 @@ RealSpaceCanvas::RealSpaceCanvas(SampleModel* sampleModel, QWidget* parent)
     : QWidget(parent)
     , m_sampleModel(sampleModel)
     , m_view(new GUI::RealSpace::Widget3D)
-    , m_view_locked(false)
     , m_cautionSign(new CautionSign(this))
     , m_currentItem(nullptr)
 {
@@ -46,6 +45,7 @@ void RealSpaceCanvas::setCurrentItem(SessionItem* item)
 {
     m_currentItem = item;
     updateScene();
+    defaultView(); // Enforces default view and also sets the zoomLevel to default i.e. 0
 }
 
 void RealSpaceCanvas::changeLayerSize(double layerSizeChangeScale)
@@ -126,15 +126,8 @@ void RealSpaceCanvas::updateScene()
 
     try {
         m_cautionSign->clear();
-        // if the view is locked, keep the current orientation of the camera
-        if (m_view_locked)
-            builder3D.populate(m_realSpaceModel.get(), *m_currentItem, m_sceneGeometry,
-                               m_view->cam().getPos());
-        // otherwise use default orientation of camera
-        else {
-            builder3D.populate(m_realSpaceModel.get(), *m_currentItem, m_sceneGeometry);
-            defaultView(); // Enforces default view and also sets the zoomLevel to default i.e. 0
-        }
+        builder3D.populate(m_realSpaceModel.get(), *m_currentItem, m_sceneGeometry,
+                           m_view->cam().getPos());
     } catch (const std::exception& ex) {
         m_cautionSign->setCautionMessage(ex.what());
     } catch (...) {

GUI/View/Realspace/RealSpaceCanvas.h

@@ -41,11 +41,9 @@ public:
     RealSpaceCanvas(SampleModel* sampleModel, QWidget* parent = nullptr);
 
     void setCurrentItem(SessionItem* item);
-
     void defaultView();
     void sideView();
     void topView();
-
     void changeLayerSize(double layer_size_scale);
     void savePicture();
 
@@ -63,7 +61,6 @@ private:
     SampleModel* m_sampleModel;
     GUI::RealSpace::Widget3D* m_view;
     std::unique_ptr<GUI::RealSpace::Model> m_realSpaceModel;
-    bool m_view_locked;
     SceneGeometry m_sceneGeometry;
     CautionSign* m_cautionSign;
     SessionItem* m_currentItem;