"" instead of QString() in default argument or return value

GUI/coregui/Models/ComboProperty.h

@@ -29,7 +29,7 @@ public:
     ComboProperty();
 
     static ComboProperty fromList(const QStringList& values,
-                                  const QString& current_value = QString());
+                                  const QString& current_value = "");
 
     QString getValue() const;
     void setValue(const QString& name);

GUI/coregui/Models/GUIDomainSampleVisitor.h

@@ -37,7 +37,7 @@ public:
 
     SessionItem* populateSampleModel(SampleModel* sampleModel, MaterialModel* materialModel,
                                      const MultiLayer& sample,
-                                     const QString& sample_name = QString());
+                                     const QString& sample_name = "");
 
     using INodeVisitor::visit;
 

GUI/coregui/Models/GUIObjectBuilder.h

@@ -39,11 +39,11 @@ BA_CORE_API_ SessionItem* populateSampleModelFromSim(SampleModel* sampleModel,
 BA_CORE_API_ SessionItem* populateSampleModel(SampleModel* sampleModel,
                                               MaterialModel* materialModel,
                                               const MultiLayer& sample,
-                                              const QString& sample_name = QString());
+                                              const QString& sample_name = "");
 
 BA_CORE_API_ SessionItem* populateInstrumentModel(InstrumentModel* p_instrument_model,
                                                   const Simulation& simulation,
-                                                  const QString& instrument_name = QString());
+                                                  const QString& instrument_name = "");
 
 BA_CORE_API_ SessionItem* populateDocumentModel(DocumentModel* p_documentModel,
                                                 const Simulation& simulation);

GUI/coregui/Models/GroupInfo.cpp

@@ -39,7 +39,7 @@ void GroupInfo::add(const QString& itemType, const QString& itemLabel)
 
 QString GroupInfo::defaultType() const
 {
-    if (m_defaultItemType == QString() && m_info.size() != 0)
+    if (m_defaultItemType == "" && m_info.size() != 0)
         return m_info[0].m_itemType;
     return m_defaultItemType;
 }

GUI/coregui/Models/GroupInfo.h

@@ -26,7 +26,7 @@
 class BA_CORE_API_ GroupInfo
 {
 public:
-    explicit GroupInfo(const QString& groupType = QString(), bool is_sorted = true);
+    explicit GroupInfo(const QString& groupType = "", bool is_sorted = true);
 
     void add(const QString& itemType, const QString& itemLabel);
 

GUI/coregui/Models/JobItemUtils.cpp

@@ -132,7 +132,7 @@ ComboProperty JobItemUtils::availableUnits(const IUnitConverter& converter)
     ComboProperty result;
     for (auto units : converter.availableUnits()) {
         auto unit_name = nameFromAxesUnits(units);
-        if (unit_name != QString())
+        if (unit_name != "")
             result << unit_name;
     }
 

GUI/coregui/Models/ModelPath.cpp

@@ -28,7 +28,7 @@ QString ModelPath::getPathFromIndex(const QModelIndex& index)
         std::reverse(namePath.begin(), namePath.end());
         return namePath.join("/");
     }
-    return QString();
+    return "";
 }
 
 // TODO cover with unit tests and simplify

GUI/coregui/Models/ModelUtils.h

@@ -26,7 +26,7 @@ class SessionModel;
 namespace ModelUtils
 {
 //! Returns list of top iten manes.
-BA_CORE_API_ QStringList topItemNames(SessionModel* model, const QString& modelType = QString());
+BA_CORE_API_ QStringList topItemNames(SessionModel* model, const QString& modelType = "");
 
 //! Iterates through all model indices and calls user function.
 BA_CORE_API_ void iterate(const QModelIndex& index, const QAbstractItemModel* model,

GUI/coregui/Models/SessionGraphicsItem.h

@@ -25,7 +25,7 @@ public:
     static const QString P_YPOS;
 
 protected:
-    explicit SessionGraphicsItem(const QString& model_type = QString());
+    explicit SessionGraphicsItem(const QString& model_type = "");
 };
 
 #endif // BORNAGAIN_GUI_COREGUI_MODELS_SESSIONGRAPHICSITEM_H

GUI/coregui/Models/SessionItem.h

@@ -33,7 +33,7 @@ class BA_CORE_API_ SessionItem
 public:
     static const QString P_NAME;
 
-    explicit SessionItem(const QString& modelType = QString());
+    explicit SessionItem(const QString& modelType = "");
     virtual ~SessionItem();
     SessionModel* model() const;
     SessionItem* parent() const;
@@ -59,10 +59,10 @@ public:
     QVector<QString> acceptableDefaultItemTypes() const;
 
     // access tagged items
-    SessionItem* getItem(const QString& tag = QString(), int row = 0) const;
+    SessionItem* getItem(const QString& tag = "", int row = 0) const;
     template <typename T> T& item(const QString& tag) const;
-    QVector<SessionItem*> getItems(const QString& tag = QString()) const;
-    bool insertItem(int row, SessionItem* item, const QString& tag = QString());
+    QVector<SessionItem*> getItems(const QString& tag = "") const;
+    bool insertItem(int row, SessionItem* item, const QString& tag = "");
     SessionItem* takeItem(int row, const QString& tag);
 
     // convenience functions for properties

GUI/coregui/Models/SessionItemTags.cpp

@@ -114,7 +114,7 @@ int SessionItemTags::insertIndexFromTagRow(const QString& tagName, int row)
 QString SessionItemTags::tagFromIndex(int index) const
 {
     if (index < 0)
-        return QString();
+        return "";
 
     for (const auto& tag : m_tags) {
         if (index < tag.childCount)
@@ -123,7 +123,7 @@ QString SessionItemTags::tagFromIndex(int index) const
             index -= tag.childCount;
     }
 
-    return QString();
+    return "";
 }
 
 int SessionItemTags::childCount(const QString& tagName)

GUI/coregui/Models/SessionItemTags.h

@@ -27,7 +27,7 @@ class BA_CORE_API_ SessionItemTags
 public:
     bool registerTag(const QString& name, int min, int max, const QStringList& modelTypes);
 
-    bool isValid(const QString& tagName, const QString& modelType = QString()) const;
+    bool isValid(const QString& tagName, const QString& modelType = "") const;
 
     QStringList modelTypesForTag(const QString& tagName) const;
 

GUI/coregui/Models/SessionModel.h

@@ -55,7 +55,7 @@ public:
 
     QModelIndex indexOfItem(SessionItem* item) const;
     SessionItem* insertNewItem(QString model_type, const QModelIndex& parent = QModelIndex(),
-                               int row = -1, QString tag = QString());
+                               int row = -1, QString tag = "");
 
     QString getModelTag() const;
     QString getModelName() const;
@@ -63,8 +63,8 @@ public:
     QVector<QString> acceptableDefaultItemTypes(const QModelIndex& parent) const;
 
     virtual void clear();
-    void load(const QString& filename = QString());
-    void save(const QString& filename = QString());
+    void load(const QString& filename = "");
+    void save(const QString& filename = "");
 
     // Sets mimedata pointer of item being dragged
     void setDraggedItemType(const QString& type);
@@ -76,10 +76,10 @@ public:
     void writeTo(QXmlStreamWriter* writer, SessionItem* parent = 0);
 
     SessionItem* moveItem(SessionItem* item, SessionItem* new_parent = 0, int row = -1,
-                          const QString& tag = QString());
+                          const QString& tag = "");
 
     SessionItem* copyItem(const SessionItem* item_to_copy, SessionItem* new_parent = 0,
-                          const QString& tag = QString());
+                          const QString& tag = "");
 
     virtual SessionModel* createCopy(SessionItem* parent = 0);
 

GUI/coregui/Models/SessionXML.h

@@ -57,7 +57,7 @@ BA_CORE_API_ void writeItemAndChildItems(QXmlStreamWriter* writer, const Session
 BA_CORE_API_ void writeVariant(QXmlStreamWriter* writer, QVariant variant, int role);
 
 BA_CORE_API_ void readItems(QXmlStreamReader* reader, SessionItem* parent,
-                            QString topTag = QString(), MessageService* messageService = nullptr);
+                            QString topTag = "", MessageService* messageService = nullptr);
 BA_CORE_API_ QString readProperty(QXmlStreamReader* reader, SessionItem* item,
                                   MessageService* messageService = nullptr);
 } // namespace SessionXML

GUI/coregui/Views/ImportDataWidgets/CsvImportAssistant/CsvImportTable.cpp

@@ -161,7 +161,7 @@ double CsvImportData::multiplier(CsvImportData::DATA_TYPE type) const
 QString CsvImportData::columnLabel(CsvImportData::DATA_TYPE type) const
 {
     if (m_selected_cols.find(type) == m_selected_cols.end())
-        return QString();
+        return "";
     return csv::HeaderLabels[m_selected_cols.at(type).name()];
 }
 

GUI/coregui/Views/ImportDataWidgets/RealDataPropertiesWidget.cpp

@@ -143,7 +143,7 @@ void RealDataPropertiesWidget::onInstrumentMapUpdate()
         m_instrumentCombo->setCurrentIndex(index);
     } else {
         // instrument corresponding to m_current_id was deleted
-        m_current_id = QString();
+        m_current_id = "";
         m_instrumentCombo->setCurrentIndex(0);
     }
     setComboConnected(true);

GUI/coregui/Views/InfoWidgets/ComboSelectorDialog.h

@@ -31,7 +31,7 @@ class BA_CORE_API_ ComboSelectorDialog : public QDialog
 public:
     ComboSelectorDialog(QWidget* parent = 0);
 
-    void addItems(const QStringList& selection, const QString& currentItem = QString());
+    void addItems(const QStringList& selection, const QString& currentItem = "");
     void setTextTop(const QString& text);
     void setTextBottom(const QString& text);
 

GUI/coregui/Views/InfoWidgets/ProjectLoadWarningDialog.h

@@ -34,7 +34,7 @@ class BA_CORE_API_ ProjectLoadWarningDialog : public QDialog
 
 public:
     ProjectLoadWarningDialog(QWidget* parent, const MessageService* messageService = 0,
-                             const QString& documentVersion = QString());
+                             const QString& documentVersion = "");
 
 private:
     QWidget* createTopPanel();

GUI/coregui/Views/InfoWidgets/PythonSyntaxHighlighter.h

@@ -82,7 +82,7 @@ private:
     bool matchMultiline(const QString& text, const QRegExp& delimiter, const int inState,
                         const QTextCharFormat& style);
     const QTextCharFormat getTextCharFormat(const QString& colorName,
-                                            const QString& style = QString());
+                                            const QString& style = "");
 
     QList<HighlightingRule> rules;
     QRegExp triSingleQuote;

GUI/coregui/Views/IntensityDataWidgets/SavePlotAssistant.cpp

@@ -138,7 +138,7 @@ QString SavePlotAssistant::getExtensionFromFilterName(const QString& filterName)
             return m_formats[i].m_file_extention;
         }
     }
-    return QString();
+    return "";
 }
 
 bool SavePlotAssistant::isPngFile(const QString& fileName) const