Merge pull request #1140 from mpuchner/issue-2510-Unreadable_text_in_error_dialogs

fix for issue 2510 "GUI: Unreadable text in error dialogs"

GUI/coregui/utils/GUIHelpers.cpp

@@ -45,7 +45,7 @@ namespace GUIHelpers {
 Error::~Error() noexcept = default;
 
 const char* Error::what() const noexcept {
-    return message.toLatin1().data();
+    return m_messageAsLatin1.data();
 }
 
 void information(QWidget* parent, const QString& title, const QString& text,

GUI/coregui/utils/GUIHelpers.h

@@ -26,7 +26,7 @@ class RealDataItem;
 namespace GUIHelpers {
 class Error : public std::exception {
 public:
-    explicit Error(const QString& message) noexcept : message(message) {}
+    explicit Error(const QString& message) noexcept : m_messageAsLatin1(message.toLatin1()) {}
     virtual ~Error() noexcept;
 
     Error(const Error&) = default;
@@ -37,7 +37,7 @@ public:
     const char* what() const noexcept override;
 
 private:
-    QString message;
+    QByteArray m_messageAsLatin1;
 };
 
 void information(QWidget* parent, const QString& title, const QString& text,