ditto for '== true'

Tests/UnitTests/GUI/TestComponentProxyModel.cpp

@@ -273,7 +273,7 @@ TEST_F(TestComponentProxyModel, test_componentStrategy)
     EXPECT_FALSE(ffProxyIndex.isValid() );
 
     QModelIndex radiusProxyIndex = proxy.mapFromSource(radiusIndex);
-    EXPECT_TRUE(radiusProxyIndex.isValid() == true);
+    EXPECT_TRUE(radiusProxyIndex.isValid() );
     EXPECT_TRUE(radiusProxyIndex.parent() == groupProxyIndex);
 }
 

Tests/UnitTests/GUI/TestExternalProperty.cpp

@@ -17,18 +17,18 @@ TEST_F(TestExternalProperty, test_initialState)
     ExternalProperty property;
     EXPECT_FALSE(property.isValid() );
     EXPECT_FALSE(property.color().isValid() );
-    EXPECT_TRUE(property.identifier().isEmpty() == true);
-    EXPECT_TRUE(property.text().isEmpty() == true);
+    EXPECT_TRUE(property.identifier().isEmpty() );
+    EXPECT_TRUE(property.text().isEmpty() );
 
     // changing any property should change state to valid
     property.setColor(QColor(Qt::red));
     EXPECT_TRUE(property.color() == QColor(Qt::red));
-    EXPECT_TRUE(property.isValid() == true);
+    EXPECT_TRUE(property.isValid() );
     property.setColor(QColor());
     EXPECT_FALSE(property.isValid() );
     property.setText("aaa");
     EXPECT_TRUE(property.text() == "aaa");
-    EXPECT_TRUE(property.isValid() == true);
+    EXPECT_TRUE(property.isValid() );
     property.setText(QString());
     EXPECT_FALSE(property.isValid() );
 }

Tests/UnitTests/GUI/TestGroupItem.cpp

@@ -76,7 +76,7 @@ TEST_F(TestGroupItem, test_CreateGroup)
 
     // checking current variant
     QVariant value = groupItem->value();
-    EXPECT_TRUE(value.canConvert<ComboProperty>() == true);
+    EXPECT_TRUE(value.canConvert<ComboProperty>() );
     ComboProperty combo = value.value<ComboProperty>();
     EXPECT_EQ(combo.getValues(), groupInfo.itemLabels());
     int index = groupInfo.itemTypes().indexOf(groupInfo.defaultType());

Tests/UnitTests/GUI/TestMapperCases.cpp

@@ -49,5 +49,5 @@ TEST_F(TestMapperCases, test_SimulationOptionsComputationToggle)
 
     combo.setValue("Monte-Carlo Integration");
     item->setItemValue(SimulationOptionsItem::P_COMPUTATION_METHOD, combo.variant());
-    EXPECT_TRUE(item->getItem(SimulationOptionsItem::P_MC_POINTS)->isEnabled() == true);
+    EXPECT_TRUE(item->getItem(SimulationOptionsItem::P_MC_POINTS)->isEnabled() );
 }

Tests/UnitTests/GUI/TestOutputDataIOService.cpp

@@ -103,7 +103,7 @@ TEST_F(TestOutputDataIOService, test_OutputDataSaveInfo)
 
     QTest::qSleep(nap_time);
     item->setLastModified(QDateTime::currentDateTime());
-    EXPECT_TRUE(info.wasModifiedSinceLastSave() == true);
+    EXPECT_TRUE(info.wasModifiedSinceLastSave() );
 }
 
 //! Tests OutputDataDirHistory class intended for storing save history of several
@@ -123,13 +123,13 @@ TEST_F(TestOutputDataIOService, test_OutputDataDirHistory)
     OutputDataDirHistory history;
     EXPECT_FALSE(history.contains(item1) );
     // non-existing item is treated as modified
-    EXPECT_TRUE(history.wasModifiedSinceLastSave(item1) == true);
+    EXPECT_TRUE(history.wasModifiedSinceLastSave(item1) );
 
     // Saving item in a history
     history.markAsSaved(item1);
     history.markAsSaved(item2);
 
-    EXPECT_TRUE(history.contains(item1) == true);
+    EXPECT_TRUE(history.contains(item1) );
     // Empty DataItems are not added to history:
     EXPECT_FALSE(history.contains(item2) );
     EXPECT_FALSE(history.wasModifiedSinceLastSave(item1) );
@@ -141,7 +141,7 @@ TEST_F(TestOutputDataIOService, test_OutputDataDirHistory)
     QTest::qSleep(10);
     item1->setLastModified(QDateTime::currentDateTime());
 
-    EXPECT_TRUE(history.wasModifiedSinceLastSave(item1) == true);
+    EXPECT_TRUE(history.wasModifiedSinceLastSave(item1) );
 }
 
 //! Tests OutputDataIOHistory class (save info for several independent directories).
@@ -174,8 +174,8 @@ TEST_F(TestOutputDataIOService, test_OutputDataIOHistory)
     history.setHistory("dir1", dirHistory1);
     history.setHistory("dir2", dirHistory2);
 
-    EXPECT_TRUE(history.wasModifiedSinceLastSave("dir1", item1) == true);
-    EXPECT_TRUE(history.wasModifiedSinceLastSave("dir2", item1) == true);
+    EXPECT_TRUE(history.wasModifiedSinceLastSave("dir1", item1) );
+    EXPECT_TRUE(history.wasModifiedSinceLastSave("dir2", item1) );
 
     EXPECT_FALSE(history.wasModifiedSinceLastSave("dir1", item2) );
     EXPECT_TRUE(history.wasModifiedSinceLastSave("dir2", item2)

Tests/UnitTests/GUI/TestParticleCoreShell.cpp

@@ -106,7 +106,7 @@ TEST_F(TestParticleCoreShell, test_distributionContext)
     // coreshell particle
     SessionItem* coreshell = model.insertNewItem("ParticleCoreShell");
     coreshell->setItemValue(ParticleItem::P_ABUNDANCE, 0.2);
-    EXPECT_TRUE(coreshell->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() == true);
+    EXPECT_TRUE(coreshell->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() );
     EXPECT_EQ(coreshell->getItemValue(ParticleItem::P_ABUNDANCE).toDouble(), 0.2);
 
     // create distribution, adding coreshell to it

Tests/UnitTests/GUI/TestParticleItem.cpp

@@ -54,7 +54,7 @@ TEST_F(TestParticleItem, test_distributionContext)
     SampleModel model;
     SessionItem* particle = model.insertNewItem("Particle");
     particle->setItemValue(ParticleItem::P_ABUNDANCE, 0.2);
-    EXPECT_TRUE(particle->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() == true);
+    EXPECT_TRUE(particle->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() );
     EXPECT_EQ(particle->getItemValue(ParticleItem::P_ABUNDANCE).toDouble(), 0.2);
 
     // adding particle to distribution, checking that abundance is default
@@ -65,6 +65,6 @@ TEST_F(TestParticleItem, test_distributionContext)
 
     // removing particle, checking that abundance is enabled again
     distribution->takeRow(ParentRow(*particle));
-    EXPECT_TRUE(particle->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() == true);
+    EXPECT_TRUE(particle->getItem(ParticleItem::P_ABUNDANCE)->isEnabled() );
     delete particle;
 }

Tests/UnitTests/GUI/TestProjectUtils.cpp

@@ -31,7 +31,7 @@ TEST_F(TestProjectUtils, test_nonXMLDataInDir)
 
     QDir dir(projectDir);
     if (dir.exists()) {
-        EXPECT_TRUE(ProjectUtils::removeRecursively(projectDir) == true);
+        EXPECT_TRUE(ProjectUtils::removeRecursively(projectDir) );
         EXPECT_FALSE(dir.exists() );
     }
 
@@ -61,7 +61,7 @@ TEST_F(TestProjectUtils, test_nonXMLDataInDir)
     EXPECT_EQ(test_nonxml_files, nonxml);
 
     std::cout << "remove nonxml files ..." << std::endl;
-    EXPECT_TRUE(ProjectUtils::removeFiles(projectDir, nonxml) == true);
+    EXPECT_TRUE(ProjectUtils::removeFiles(projectDir, nonxml) );
 
     std::cout << "check that no files left ..." << std::endl;
     nonxml = ProjectUtils::nonXMLDataInDir(projectDir);