Make Instrument2DItem::P_DETECTOR private

GUI/Models/InstrumentItems.cpp

@@ -274,6 +274,11 @@ std::unique_ptr<Instrument> Instrument2DItem::createInstrument() const
     return result;
 }
 
+bool Instrument2DItem::isDetectorPropertyName(const QString& name)
+{
+    return name == P_DETECTOR;
+}
+
 
 //  ************************************************************************************************
 //  class GISASInstrumentItem

GUI/Models/InstrumentItems.h

@@ -89,9 +89,11 @@ public:
 
 
 class BA_CORE_API_ Instrument2DItem : public InstrumentItem {
-public:
+private:
     static const QString P_DETECTOR;
 
+public:
+
     ~Instrument2DItem() override;
 
     DetectorItem* detectorItem() const;
@@ -104,6 +106,8 @@ public:
 
     std::unique_ptr<Instrument> createInstrument() const override;
 
+    static bool isDetectorPropertyName(const QString& name);
+
 protected:
     explicit Instrument2DItem(const QString& modelType);
 };

GUI/Views/InstrumentWidgets/GISASDetectorEditor.cpp

@@ -37,7 +37,7 @@ void GISASDetectorEditor::subscribeToItem()
 {
     currentItem()->mapper()->setOnPropertyChange(
         [this](const QString& name) {
-            if (name == Instrument2DItem::P_DETECTOR)
+            if (Instrument2DItem::isDetectorPropertyName(name))
                 updateDetectorPresenter();
         },
         this);

GUI/Views/InstrumentWidgets/PolarizationAnalysisEditor.cpp

@@ -59,7 +59,7 @@ void PolarizationAnalysisEditor::subscribeToItem()
 
     currentItem()->mapper()->setOnPropertyChange(
         [this](const QString& name) {
-            if (name == Instrument2DItem::P_DETECTOR)
+            if (Instrument2DItem::isDetectorPropertyName(name))
                 updateAnalyserEditor();
         },
         this);