improve encapsulation of native output data in realDataItem

GUI/coregui/Models/InstrumentItems.cpp

@@ -151,7 +151,7 @@ void SpecularInstrumentItem::updateToRealData(const RealDataItem* item)
         throw GUIHelpers::Error("Error in SpecularInstrumentItem::updateToRealData: The type "
                                 "of instrument is incompatible with passed data shape.");
 
-    const auto& data = item->nativeData()->getOutputData()->axis(0);
+    const auto& data = item->nativeOutputData()->axis(0);
     beamItem()->updateToData(data, item->nativeDataUnits());
 }
 
@@ -172,7 +172,7 @@ bool SpecularInstrumentItem::alignedWith(const RealDataItem* item) const
         if (!instrument_axis)
             return false;
 
-        const auto& native_axis = item->nativeData()->getOutputData()->axis(0);
+        const auto& native_axis = item->nativeOutputData()->axis(0);
         return *instrument_axis == native_axis;
         ;
     }

GUI/coregui/Models/JobModelFunctions.cpp

@@ -207,8 +207,7 @@ void JobModelFunctions::copyRealDataItem(JobItem* jobItem, const RealDataItem* r
     if (!realDataItem->nativeData())
         return;
 
-    realDataItemCopy->nativeData()->setOutputData(
-        realDataItem->nativeData()->getOutputData()->clone());
+    realDataItemCopy->setNativeOutputData(realDataItem->nativeOutputData()->clone());
     realDataItemCopy->nativeData()->setFileName(ItemFileNameUtils::jobNativeDataFileName(*jobItem));
 }
 

GUI/coregui/Models/RealDataItem.cpp

@@ -150,6 +150,18 @@ bool RealDataItem::hasNativeData() const
     return (nativeData() != nullptr) && (nativeData()->getOutputData() != nullptr);
 }
 
+const OutputData<double>* RealDataItem::nativeOutputData() const
+{
+    return hasNativeData() ? nativeData()->getOutputData() : nullptr;
+}
+
+//! takes ownership of data
+
+void RealDataItem::setNativeOutputData(OutputData<double>* data)
+{
+    nativeData()->setOutputData(data); // takes ownership of odata
+}
+
 //! Creates data item if not existing so far. Checks for rank compatibility if already existing. No
 //! further initialization like clearing the data etc.
 

GUI/coregui/Models/RealDataItem.h

@@ -67,7 +67,9 @@ public:
     void initNativeData();
     QString nativeDataUnits() const;
     void setNativeDataUnits(const QString& units);
-    bool hasNativeData() const;   
+    bool hasNativeData() const;
+    const OutputData<double>* nativeOutputData() const;
+    void setNativeOutputData(OutputData<double>* data);
 
     void setOutputData(OutputData<double>* data);
     void setImportData(ImportDataInfo data);