From de866cb98c9d4eb7cc2ff9e2f4647d6bc80453e1 Mon Sep 17 00:00:00 2001 From: schroedtert <t.schroedter@fz-juelich.de> Date: Thu, 23 Feb 2023 10:07:51 +0100 Subject: [PATCH 1/2] Allow the prebuild checks to fail --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9e8c9e4ae..c64dbcc9a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -45,6 +45,7 @@ pre-build-checks: stage: pre-build-checks script: - scripts/check-format-cpp.sh + allow_failure: true # Build petrack and petrack unit_tests build_linux: -- GitLab From 79b1604c4d20d61f4ca664725e5a20bd81115f93 Mon Sep 17 00:00:00 2001 From: schroedtert <t.schroedter@fz-juelich.de> Date: Thu, 23 Feb 2023 11:44:09 +0100 Subject: [PATCH 2/2] Add formatting check to reviewer checklist --- .gitlab/merge_request_templates/merge_request.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitlab/merge_request_templates/merge_request.md b/.gitlab/merge_request_templates/merge_request.md index 5a322092f..2cddf8440 100644 --- a/.gitlab/merge_request_templates/merge_request.md +++ b/.gitlab/merge_request_templates/merge_request.md @@ -3,6 +3,9 @@ # Reviewer Checklist +## Formatting +- [ ] the pre-build checks succeed + ## General code quality - [ ] naming conventions are met (see .clang-tidy for detailed information) - [ ] no static analyzer warnings in new code parts (e.g., use clang-tidy for checking) -- GitLab