From bd12c5246e2ca0b13ad9bd06c160740f879754fe Mon Sep 17 00:00:00 2001
From: "Joachim Wuttke (h)" <j.wuttke@fz-juelich.de>
Date: Thu, 9 Sep 2021 09:37:49 +0200
Subject: [PATCH] early return
---
GUI/Views/SampleDesigner/DesignerScene.cpp | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/GUI/Views/SampleDesigner/DesignerScene.cpp b/GUI/Views/SampleDesigner/DesignerScene.cpp
index 454599f3ba0..7dc9ef1df33 100644
--- a/GUI/Views/SampleDesigner/DesignerScene.cpp
+++ b/GUI/Views/SampleDesigner/DesignerScene.cpp
@@ -227,17 +227,15 @@ IView* DesignerScene::addViewForItem(SessionGraphicsItem* item)
{
ASSERT(item);
- IView* view = getViewForItem(item);
+ if (IView* view = getViewForItem(item))
+ return view;
- if (!view) {
- view = SampleViewFactory::createSampleView(item->modelType());
- if (view) {
- m_ItemToView[item] = view;
- view->setParameterizedItem(item);
- addItem(view);
- return view;
- }
- }
+ IView* view = SampleViewFactory::createSampleView(item->modelType());
+ if (!view)
+ return nullptr;
+ m_ItemToView[item] = view;
+ view->setParameterizedItem(item);
+ addItem(view);
return view;
}
--
GitLab