From ab78968cc00c82e74e61262954345448d364b189 Mon Sep 17 00:00:00 2001
From: Mikhail Svechnikov <m.svechnikov@fz-juelich.de>
Date: Mon, 18 Nov 2024 13:26:32 +0100
Subject: [PATCH] properly update job status in list
---
GUI/Model/Job/JobsSet.cpp | 2 +-
GUI/Model/Job/JobsSet.h | 1 -
GUI/View/Job/JobsQModel.cpp | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/GUI/Model/Job/JobsSet.cpp b/GUI/Model/Job/JobsSet.cpp
index 9b0845cf01b..6e232247cc1 100644
--- a/GUI/Model/Job/JobsSet.cpp
+++ b/GUI/Model/Job/JobsSet.cpp
@@ -56,7 +56,7 @@ void JobsSet::readFrom(QXmlStreamReader* r)
if (tag == Tag::Job) {
auto* job_item = createJobItem();
XML::readTaggedElement(r, tag, *job_item);
- emit updJobView(job_item);
+ emit jobAdded(job_item);
} else if (tag == Tag::CurrentIndex) {
size_t i = XML::readTaggedInt(r, tag);
setCurrentIndex(i);
diff --git a/GUI/Model/Job/JobsSet.h b/GUI/Model/Job/JobsSet.h
index 5f13b86e4cf..7f85765ab1e 100644
--- a/GUI/Model/Job/JobsSet.h
+++ b/GUI/Model/Job/JobsSet.h
@@ -54,7 +54,6 @@ signals:
void jobMeritsAttention(JobItem* item) const;
void globalProgress(int);
void jobAdded(JobItem* job_item);
- void updJobView(JobItem* job_item);
void setChanged();
private slots:
diff --git a/GUI/View/Job/JobsQModel.cpp b/GUI/View/Job/JobsQModel.cpp
index f6b444ffe83..5dd78644500 100644
--- a/GUI/View/Job/JobsQModel.cpp
+++ b/GUI/View/Job/JobsQModel.cpp
@@ -26,7 +26,6 @@ JobsQModel::JobsQModel(QObject* parent)
: QAbstractListModel(parent)
{
connect(gDoc->jobsRW(), &JobsSet::jobAdded, this, &JobsQModel::onJobAdded);
- connect(gDoc->jobsRW(), &JobsSet::updJobView, this, &JobsQModel::emitJobsQModelChanged);
}
JobsQModel::~JobsQModel() = default;
@@ -99,4 +98,5 @@ void JobsQModel::onJobAdded(JobItem* job)
[this, job] { emitJobsQModelChanged(job); });
connect(job->batchInfo(), &BatchInfo::jobProgressChanged,
[this, job] { emitJobsQModelChanged(job); });
+ emitJobsQModelChanged(job);
}
--
GitLab