From a9b48a72a0c8cc070f47154b9c7d8455f091b464 Mon Sep 17 00:00:00 2001
From: "Joachim Wuttke (h)" <j.wuttke@fz-juelich.de>
Date: Fri, 12 Nov 2021 20:34:53 +0100
Subject: [PATCH] revert insertion of 'explicit'

---
 .clang-tidy                     |  2 +-
 Base/Axis/IAxis.h               |  2 +-
 Fit/Tools/MultiOption.h         |  4 ++--
 Param/Distrib/Distributions.h   | 12 ++++++------
 Param/Distrib/ParameterSample.h |  2 +-
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index b34d484da73..02bd88151c5 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -51,6 +51,7 @@ Checks: '
 -fuchsia-trailing-return,
 -google-build-using-namespace,
 -google-default-arguments,
+-google-explicit-constructor,
 -google-readability-casting,
 -google-readability-todo,
 -google-runtime-int,
@@ -110,7 +111,6 @@ clang-analyzer-optin.cplusplus.VirtualCall,
 cppcoreguidelines-explicit-virtual-functions,
 cppcoreguidelines-pro-type-const-cast,
 cppcoreguidelines-pro-type-static-cast-downcast,
-google-explicit-constructor,
 google-readability-avoid-underscore-in-googletest-name,
 google-runtime-references,
 hicpp-explicit-conversions,
diff --git a/Base/Axis/IAxis.h b/Base/Axis/IAxis.h
index de41b692c1d..6810ebf8d42 100644
--- a/Base/Axis/IAxis.h
+++ b/Base/Axis/IAxis.h
@@ -24,7 +24,7 @@
 
 class IAxis {
 public:
-    explicit IAxis(std::string name) : m_name(std::move(name)) {}
+    IAxis(std::string name) : m_name(std::move(name)) {}
     IAxis(const IAxis&) = delete;
     virtual ~IAxis() = default;
 
diff --git a/Fit/Tools/MultiOption.h b/Fit/Tools/MultiOption.h
index 996967a335e..c7f663fe812 100644
--- a/Fit/Tools/MultiOption.h
+++ b/Fit/Tools/MultiOption.h
@@ -29,10 +29,10 @@ class MultiOption {
 public:
     using variant_t = std::variant<int, double, std::string>;
 
-    explicit MultiOption(std::string name = "");
+    MultiOption(std::string name = "");
 
     template <typename T>
-    explicit MultiOption(const std::string& name, const T& t, const std::string& descripion = "");
+    MultiOption(const std::string& name, const T& t, const std::string& descripion = "");
 
     std::string name() const;
 
diff --git a/Param/Distrib/Distributions.h b/Param/Distrib/Distributions.h
index 676685668a9..896b7ed380c 100644
--- a/Param/Distrib/Distributions.h
+++ b/Param/Distrib/Distributions.h
@@ -91,7 +91,7 @@ public:
     inline static const std::string class_name = "DistributionGate";
     std::string className() const final { return class_name; }
 
-    explicit DistributionGate(std::vector<double> P);
+    DistributionGate(std::vector<double> P);
     DistributionGate(double min, double max);
     DistributionGate();
 
@@ -131,7 +131,7 @@ public:
     inline static const std::string class_name = "DistributionLorentz";
     std::string className() const final { return class_name; }
 
-    explicit DistributionLorentz(std::vector<double> P);
+    DistributionLorentz(std::vector<double> P);
     DistributionLorentz(double mean, double hwhm);
     DistributionLorentz();
 
@@ -170,7 +170,7 @@ public:
     inline static const std::string class_name = "DistributionGaussian";
     std::string className() const final { return class_name; }
 
-    explicit DistributionGaussian(std::vector<double> P);
+    DistributionGaussian(std::vector<double> P);
     DistributionGaussian(double mean, double std_dev);
     DistributionGaussian();
 
@@ -212,7 +212,7 @@ public:
     inline static const std::string class_name = "DistributionLogNormal";
     std::string className() const final { return class_name; }
 
-    explicit DistributionLogNormal(std::vector<double> P);
+    DistributionLogNormal(std::vector<double> P);
     DistributionLogNormal(double median, double scale_param);
 
     DistributionLogNormal* clone() const override
@@ -254,7 +254,7 @@ public:
     inline static const std::string class_name = "DistributionCosine";
     std::string className() const final { return class_name; }
 
-    explicit DistributionCosine(std::vector<double> P);
+    DistributionCosine(std::vector<double> P);
     DistributionCosine(double mean, double sigma);
     DistributionCosine();
 
@@ -293,7 +293,7 @@ public:
     inline static const std::string class_name = "DistributionTrapezoid";
     std::string className() const final { return class_name; }
 
-    explicit DistributionTrapezoid(std::vector<double> P);
+    DistributionTrapezoid(std::vector<double> P);
     DistributionTrapezoid(double center, double left, double middle, double right);
     DistributionTrapezoid();
 
diff --git a/Param/Distrib/ParameterSample.h b/Param/Distrib/ParameterSample.h
index 3213fb4a1e7..c57c667c904 100644
--- a/Param/Distrib/ParameterSample.h
+++ b/Param/Distrib/ParameterSample.h
@@ -19,7 +19,7 @@
 
 class ParameterSample {
 public:
-    explicit ParameterSample(double _value = 0., double _weight = 1.)
+    ParameterSample(double _value = 0., double _weight = 1.)
         : value(_value), weight(_weight)
     {
     }
-- 
GitLab